Alex Moreno
← All posts

Notes on code review etiquette

· 1 min read

Review the change, not the person; ask before you assert; and approve when it's better than before, not when it's perfect.

On this page

A few habits that made my reviews kinder and faster.

  • Ask before you assert. “What happens if this list is empty?” lands better than “This breaks on empty lists.”
  • Label your nits. If it’s optional, say so, and don’t block on it.
  • Approve improvements. The bar is better than before, not perfect.
  • Review within a day. A fast “not yet” beats a slow “looks good”.

For authors#

Small changes get better reviews. If a pull request needs a meeting to explain it, it’s probably two pull requests.